Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] #994

Merged
merged 1 commit into from
Mar 18, 2021
Merged

[CI] #994

merged 1 commit into from
Mar 18, 2021

Conversation

speth
Copy link
Member

@speth speth commented Mar 18, 2021 •
edited
Loading

Changes proposed in this pull request

  • Manually install Boost headers on Windows during CI builds

If applicable, fill in the issue number this pull request is fixing

Fixes #990

Checklist

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • The pull request is ready for review

@speth
[CI] Manually install Boost headers on Windows
bfa90f9 
GitHub has removed Boost from their default images. See
actions/runner-images#2667

Fixes Cantera#990
@speth speth requested a review from bryanwweber March 18, 2021 19:38
bryanwweber
bryanwweber approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@bryanwweber bryanwweber left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge it when the CI finishes if you see it first.

@codecov
Copy link

codecov bot commented Mar 18, 2021 •
edited
Loading

Codecov Report

Merging #994 (bfa90f9) into main (e70371a) will decrease coverage by 0.95%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
- Coverage   71.60%   70.64%   -0.96%     
==========================================
  Files         360      355       -5     
  Lines       45719    44311    -1408     
==========================================
- Hits        32736    31304    -1432     
- Misses      12983    13007      +24
Impacted Files Coverage Δ
include/cantera/transport/DustyGasTransport.h 0.00% <0.00%> (-33.34%) ⬇️
...clude/cantera/transport/HighPressureGasTransport.h 0.00% <0.00%> (-33.34%) ⬇️
include/cantera/thermo/MixtureFugacityTP.h 0.00% <0.00%> (-20.00%) ⬇️
include/cantera/thermo/VPStandardStateTP.h 50.00% <0.00%> (-16.67%) ⬇️
include/cantera/thermo/GibbsExcessVPSSTP.h 14.28% <0.00%> (-10.72%) ⬇️
include/cantera/transport/WaterTransport.h 50.00% <0.00%> (-10.00%) ⬇️
include/cantera/thermo/ConstCpPoly.h 66.66% <0.00%> (-8.34%) ⬇️
include/cantera/transport/TransportData.h 66.66% <0.00%> (-8.34%) ⬇️
test_problems/shared/fileLog.h 42.85% <0.00%> (-7.15%) ⬇️
include/cantera/zeroD/IdealGasReactor.h 50.00% <0.00%> (-7.15%) ⬇️
... and 204 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e70371a...bfa90f9. Read the comment docs.

@speth
Copy link
Member Author

speth commented Mar 18, 2021

No idea what's going on with Codecov, but it still seems like it ran OK, and there's nothing here that actually affects it.

@speth speth merged commit ae7734a into Cantera:main Mar 18, 2021
@speth speth deleted the fix-ci-boost branch March 18, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanwweber bryanwweber bryanwweber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Boost will be removed from GitHub Actions
2 participants
@speth @bryanwweber